Expose Platform specific info as expect-actual (locale, system, version) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcantoinefortier
force-pushed
the
setup/platform-info
branch
3 times, most recently
from
60f888a
to
15982a9
Compare
marcantoinefortier
force-pushed
the
setup/platform-info
branch
from
15982a9
to
e27f5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Expose information about the System name & version, the Locale languageCode & regionCode as well as the app's Version name & code using expect actual implementations.
🗒️ Notes
Providing buildConfig fields to our common android library allows us to feed the version name & version code to our androidMain implementation without having to instantiate a class in the platform modules and bubble it back up in our app entry point. (See https://www.jetbrains.com/help/kotlin-multiplatform-dev/multiplatform-connect-to-apis.html#different-entry-points)
🎉 Result